fix Warning: array_merge() #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've got this warning if I try to run `php hoimport.php -action line -profile profile_name -line 1`: ``` Getting source adapter ho_import/source_adapter_csv Warning: array_merge(): Argument #1 is not an array in app/code/community/Ho/Import/Model/Import.php on line 831 ``` `array_merge` expects first argument to be an array. `$arguments` can be string in case if line 825 was executed.
|
@razbakov Can you edit the PR for the develop branch? |
|
@paales done |
|
Thanks! |
|
@paales when are you going to release it? |
|
+1 |
|
1.7.1 is released to address this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got this warning if I try to run
php hoimport.php -action line -profile profile_name -line 1:array_mergeexpects first argument to be an array.$argumentscan be string in case if line 825 was executed.